Bootstrap v4 #18
Merged
Bootstrap v4 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They've been moved from devDependencies to dependencies because they're needed when running the code.
The Glyphicon and Label components have been removed from Bootstrap, so I've removed them from design-system too. Bootstrap v4 switches from less to sass. We now install bootstrap as a dependency and import the base .scss files from node_modules/. All of our custom changes go in scss/custom.scss. I tried my best to transfer over the previous theme (although it wasn't particularly complete). In package.json, react-bootstrap has been moved from devDependencies to dependencies because it's needed when running the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits