Ghost vs. Secondary Buttons #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure about the colors, but makes sense. :) Let me know when it's no longer WIP. |
added 2 commits
June 5, 2019 18:05
mwiencek
reviewed
Jun 6, 2019
| <div> | ||
| <Button bsStyle="primary" onClick={action('clicked')}>{'Primary Button'}</Button> | ||
| <Button bsSize="small" bsStyle="primary" onClick={action('clicked')}>{'Primary Small Button'}</Button> | ||
| </div> | ||
| ))) | ||
|
|
||
| .add('Secondary Button', withInfo('')(() => ( | ||
| .add('Default Button', withInfo('Default buttons are used for secondary actions. They’re usually paired with a primary button to provide an alternate choice.')(() => ( |
There was a problem hiding this comment.
Bootstrap v4 has a dedicated "secondary" style (and with that I'm not sure we'd ever use a default button), so I removed this in #18. If we do think a button with no set style is useful we could add it back, but it'd need a different description at least.
mwiencek
reviewed
Jun 6, 2019
| .add('Warning Button', withInfo('')(() => ( | ||
| .add('Ghost Button', withInfo('Use ghost buttons to reduce visual clutter on the screen. Take care that the actions via a ghost button are not primary actions.')(() => ( | ||
| <div> | ||
| <Button bsStyle="secondary" onClick={action('clicked')}>{'Ghost Button'}</Button> |
There was a problem hiding this comment.
In Bootstrap v4 ghost buttons seem to correspond with outline buttons (I guess they're interchangeable): https://getbootstrap.com/docs/4.0/components/buttons/#outline-buttons. So #18 changes this to use those instead of the secondary style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just realized while I was researching, that we have mistakenly put ghost buttons as secondary buttons. Fixed the examples and documentation. Still not very happy with the colors though. Will run a quick design exercise to run through all the colors in our design system to finalize this one!
PS: We might just finalize the colors in the summit when almost everyone is there.