-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
message: Allow bool #9447
message: Allow bool #9447
Conversation
TBH I don't even understand the point of writing |
Certainly something like: |
I assume printf debugging |
Codecov Report
@@ Coverage Diff @@
## master #9447 +/- ##
==========================================
- Coverage 67.31% 64.16% -3.16%
==========================================
Files 396 198 -198
Lines 85440 42685 -42755
Branches 17655 8735 -8920
==========================================
- Hits 57518 27390 -30128
+ Misses 23237 12999 -10238
+ Partials 4685 2296 -2389
Continue to review full report at Codecov.
|
It has always been working even if not documented and there is no reason to not accept it. However, change "True/False" to "true/false" to be consistent with meson language. Fixes: mesonbuild#9436
4c14954
to
5dff016
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as this is actually documented (and we print something that is actually consistent) which it now is, LGTM.
It has always been working even if not documented and there is no reason
to not accept it. However, change "True/False" to "true/false" to be
consistent with meson language.
Fixes: #9436