Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.60.0: message() does not accept bools anymore #9436

Closed
Tachi107 opened this issue Oct 24, 2021 · 2 comments · Fixed by #9447
Closed

0.60.0: message() does not accept bools anymore #9436

Tachi107 opened this issue Oct 24, 2021 · 2 comments · Fixed by #9447
Labels
bug regression
Milestone
0.60.1

Comments

@Tachi107
Copy link
Contributor

Tachi107 commented Oct 24, 2021 •
edited
Loading

Describe the bug
When passing a boolean to message(), Meson throws an error

To Reproduce
Write message(true) in your meson.build file

Expected behavior
Previous Meson versions converted booleans passed in message() to either True or False. This was useful, even if the docs say that you can only pass strings to it. I know this is technically the correct behaviour, but this is an unannounced breaking change. I would suggest reverting this change and mentioning the boolean conversion in the documentation. I believe this was introduced in 941b8a6 (edit: yes, reverting the change fixes the "issue")

system parameters

  • Debian Testing/12
  • Python 3.9.7
  • meson 0.60.0

Edit: found in marzer/tomlplusplus#121, see that issue for other details
@dcbaker dcbaker added this to the 0.60.1 milestone Oct 24, 2021
xclaesse added a commit to xclaesse/meson that referenced this issue Oct 25, 2021
@xclaesse
message: Allow bool
4c14954 
It has always been working even if not documented and there is no reason
to not accept it. However, change "True/False" to "true/false" to be
consistent with meson language.

Fixes: mesonbuild#9436
@xclaesse xclaesse mentioned this issue Oct 25, 2021
Merged
@xclaesse
Copy link
Member

Fixed here: #9447

xclaesse added a commit to xclaesse/meson that referenced this issue Oct 26, 2021
@xclaesse
message: Allow bool
5dff016 
It has always been working even if not documented and there is no reason
to not accept it. However, change "True/False" to "true/false" to be
consistent with meson language.

Fixes: mesonbuild#9436
xclaesse added a commit that referenced this issue Oct 26, 2021
@xclaesse
message: Allow bool
6298e29 
It has always been working even if not documented and there is no reason
to not accept it. However, change "True/False" to "true/false" to be
consistent with meson language.

Fixes: #9436
@Tachi107
Copy link
Contributor Author

Thanks :D

nirbheek pushed a commit that referenced this issue Oct 28, 2021
@xclaesse @nirbheek
message: Allow bool
9637bec 
It has always been working even if not documented and there is no reason
to not accept it. However, change "True/False" to "true/false" to be
consistent with meson language.

Fixes: #9436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug regression
Projects
None yet
Milestone
0.60.1
Development

Successfully merging a pull request may close this issue.

message: Allow bool xclaesse/meson
3 participants
@xclaesse @dcbaker @Tachi107