[WC-2773]: Focus lost on change #1421
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
09d8da6 to
d715198
Compare
d7bf96e to
a217f74
Compare
d715198 to
7416042
Compare
c5c2966 to
6142d4e
Compare
ed2f582 to
130575f
Compare
Base automatically changed from
feat/wc-2718/migrate-dropdown-to-downshift
to
main
February 12, 2025 10:51
0365d58 to
9f2af4c
Compare
r0b1n
reviewed
Feb 13, 2025
| isInfinite, | ||
| setPage | ||
| }); | ||
| const baseClass = "widget-datagrid-grid-body table-content"; |
There was a problem hiding this comment.
I see only one usage of this const, I guess we can inline it.
r0b1n
reviewed
Feb 13, 2025
| return this.refreshing; | ||
| } | ||
|
|
||
| get isLoadingMore(): boolean { |
There was a problem hiding this comment.
We can possibly replace Loading word in the name of this field. I am thinking we can use Fetching instead: isFetching, isFetchingNextPage, isFetchingNextBatch or something.
There was a problem hiding this comment.
I like isFetching, short and not very specific
|
Are mobx changes here because of rebase? |
No, the mobx-kit is introduced in this PR |
1562408 to
9d3cab3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Dependency changes (any modification to dependencies in
package.json)Refactoring (e.g. file rename, variable rename, etc.)
Bug fix (non-breaking change which fixes an issue)
Breaking change (fix or feature that would cause existing functionality to change)
Description
This PR finally extract grid header from body. This change how scroll is implemented. Also this PR fixes issue with loosing focus in DG filters.
What should be covered while testing?