Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WC-2761]: DG2 Empty list message and loading indicator visibility #1418

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rahmanunver
Copy link
Contributor

Pull request type

Bug fix (non-breaking change which fixes an issue)


Description

Added a control for the emptyListMessage visibility to consider the isLoading state.

@rahmanunver rahmanunver requested a review from a team as a code owner January 30, 2025 19:41
@rahmanunver rahmanunver changed the title fix(datagrid-web): add check for isloading for emptyListMessage [WC-2761]: DG2 Empty list message and loading indicator visibility/ Jan 30, 2025
@rahmanunver rahmanunver changed the title [WC-2761]: DG2 Empty list message and loading indicator visibility/ [WC-2761]: DG2 Empty list message and loading indicator visibility Jan 30, 2025
@rahmanunver rahmanunver force-pushed the wc-2761_dg2_no_rows_messag branch from 7d6f50c to ae05bc8 Compare January 31, 2025 13:57
Copy link
Collaborator

@iobuhov iobuhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a bit odd, but because I change how loader is rendered in #1421, this fix is not relevant anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants