Image flaw checking should be different for translated content #3175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3174
This is just one of the cases. But it's an important one, to start with.
Imagine there's an
en-US
page that contains<img src="foo.png">
in that English page and that works (and that there exists afoo.png
next to that Englishindex.html
). Now you copy that page totranslated-content/files/fr/*
. The page should work. No flaw. And the finalcheerio
transformation, for both theen-US
and thefr
page, should become:/en-US/docs/Foo/bar/foo.png
.Perhaps a better way to explain it is to look at the test fixtures. We have, in English:
and on the
fr
equivalent we have:What you get in the end is: