-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image flaw checking should be different for translated content #3174
Comments
peterbe
added a commit
to peterbe/yari
that referenced
this issue
Mar 9, 2021
fiji-flo
pushed a commit
that referenced
this issue
Mar 11, 2021
* Image flaw checking should be different for translated content Part of #3174 * debugging be gone * debugging be gone
peterbe
added a commit
to peterbe/yari
that referenced
this issue
Mar 11, 2021
fiji-flo
pushed a commit
that referenced
this issue
Mar 12, 2021
* downloading external images for translated-content Fixes #3174 * eslint
peterbe
added a commit
to peterbe/yari
that referenced
this issue
Jun 1, 2021
) * Image flaw checking should be different for translated content Part of mdn#3174 * debugging be gone * debugging be gone
peterbe
added a commit
to peterbe/yari
that referenced
this issue
Jun 1, 2021
* downloading external images for translated-content Fixes mdn#3174 * eslint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If a translated document has an external image like:
before downloading that image, it should see if the
en-US
equivalent already has aopera-mac-select-2-closed.png
and then the result should become:And if it's already something like:
it should not be a flaw even though there exists no
translated-content/files/fr/Web/Foo/bar/opera-mac-select-2-closed.png
.But there exists a lot of "translated images". E.g.
translated-content/files/fr/learn/forms/html_forms_in_legacy_browsers/index.html
has a https://mdn.mozillademos.org/files/16009/choix_chrome.png so in that case it should just download it because the filename is unique to French.The text was updated successfully, but these errors were encountered: