Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image flaw checking should be different for translated content #3174

Closed
peterbe opened this issue Mar 9, 2021 · 0 comments · Fixed by #3207
Closed

Image flaw checking should be different for translated content #3174

peterbe opened this issue Mar 9, 2021 · 0 comments · Fixed by #3207
Assignees

Comments

@peterbe
Copy link
Contributor

peterbe commented Mar 9, 2021

If a translated document has an external image like:

<img alt="" src="https://mdn.mozillademos.org/files/15704/opera-mac-select-2-closed.png">

before downloading that image, it should see if the en-US equivalent already has a opera-mac-select-2-closed.png and then the result should become:

<img alt="" src="/en-US/docs/Web/Foo/bar/opera-mac-select-2-closed.png">

And if it's already something like:

<img alt="" src="/en-US/docs/Web/Foo/bar/opera-mac-select-2-closed.png">

it should not be a flaw even though there exists no translated-content/files/fr/Web/Foo/bar/opera-mac-select-2-closed.png.

But there exists a lot of "translated images". E.g. translated-content/files/fr/learn/forms/html_forms_in_legacy_browsers/index.html has a https://mdn.mozillademos.org/files/16009/choix_chrome.png so in that case it should just download it because the filename is unique to French.

@peterbe peterbe self-assigned this Mar 9, 2021
peterbe added a commit to peterbe/yari that referenced this issue Mar 9, 2021
fiji-flo pushed a commit that referenced this issue Mar 11, 2021
* Image flaw checking should be different for translated content

Part of #3174

* debugging be gone

* debugging be gone
peterbe added a commit to peterbe/yari that referenced this issue Mar 11, 2021
fiji-flo pushed a commit that referenced this issue Mar 12, 2021
* downloading external images for translated-content

Fixes #3174

* eslint
peterbe added a commit to peterbe/yari that referenced this issue Jun 1, 2021
)

* Image flaw checking should be different for translated content

Part of mdn#3174

* debugging be gone

* debugging be gone
peterbe added a commit to peterbe/yari that referenced this issue Jun 1, 2021
* downloading external images for translated-content

Fixes mdn#3174

* eslint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant