Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(flaws): exclude /en-US/observatory/* from broken-link flaw #11406

Merged
merged 4 commits into from
Jul 4, 2024
Merged

chore(flaws): exclude /en-US/observatory/* from broken-link flaw #11406

merged 4 commits into from
Jul 4, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jul 3, 2024 •
edited
Loading

Summary

(MP-1320)

Problem

Linking to HTTP Observatory from content causes a flaw.

Solution

Add an exception in the broken-link flaw implementation.

Screenshots

Before

image

After

image

How did you test this change?

Ran yarn dev and checked locally:

@github-actions github-actions bot added the flaw-system issues and feature requests related to the flaws system label Jul 3, 2024
@bsmth bsmth mentioned this pull request Jul 3, 2024
Closed
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Jul 4, 2024
@caugner caugner requested a review from bsmth July 4, 2024 08:57
@caugner caugner marked this pull request as ready for review July 4, 2024 08:58
@caugner caugner requested a review from a team as a code owner July 4, 2024 08:58
bsmth
bsmth approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you, tested on localhost

@caugner caugner changed the title fix(broken-links): add exception for HTTP Observatory chore(flaws): exclude /en-US/observatory from broken-link flaw Jul 4, 2024
@caugner caugner changed the title chore(flaws): exclude /en-US/observatory from broken-link flaw chore(flaws): exclude /en-US/observatory/* from broken-link flaw Jul 4, 2024
@caugner caugner merged commit 25c3064 into main Jul 4, 2024
14 checks passed
@caugner caugner deleted the ignore-observatory-in-broken-links branch July 4, 2024 16:27
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
Merged
ferdnyc pushed a commit to ferdnyc/yari that referenced this pull request Jul 13, 2024
@caugner @ferdnyc
chore(flaws): exclude /en-US/observatory/* from broken-link flaw (mdn…
3452c79 
…#11406)
@mirunacurtean mirunacurtean mentioned this pull request Jul 23, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skysthelimit720 Skysthelimit720 Skysthelimit720 approved these changes

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
flaw-system issues and feature requests related to the flaws system macros tracking issues related to kumascript macros
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caugner @bsmth @Skysthelimit720