Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use absolute URL for observatory link #34591

Closed
wants to merge 3 commits into from
Closed

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Jul 3, 2024

Currently, the URL shows as a broken link even though it works.

Description

changes:

  • /en-US/observatory/ to https://developer.mozilla.org/en-US/observatory/
  • mdlint rule to ignore observatory link

Related PRs

@bsmth bsmth requested review from a team as code owners July 3, 2024 09:07
@bsmth bsmth requested review from hamishwillee and removed request for a team July 3, 2024 09:07
@github-actions github-actions bot added Content:Security Security docs system [PR only] Infrastructure and configuration for the project size/xs [PR only] 0-5 LoC changed labels Jul 3, 2024
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Preview URLs

Flaws (1)

URL: /en-US/docs/Web/Security/Practical_implementation_guides
Title: Practical security implementation guides
Flaw count: 1

  • broken_links:
    • Can't resolve https://developer.mozilla.org/en-US/observatory

(comment last updated: 2024-07-03 09:25:59)

@bsmth bsmth requested review from caugner and removed request for hamishwillee July 3, 2024 09:10
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observatory currently has no trailing slash.

.markdownlint.jsonc Outdated Show resolved Hide resolved
bsmth and others added 2 commits July 3, 2024 11:24
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
@bsmth bsmth marked this pull request as draft July 3, 2024 09:30
@bsmth
Copy link
Member Author

bsmth commented Jul 4, 2024

This is fixed in the linked PR instead. Closing now

@bsmth bsmth closed this Jul 4, 2024
@bsmth bsmth deleted the obs-url branch July 4, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Security Security docs size/xs [PR only] 0-5 LoC changed system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants