Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(csp): allow shared assets #10858

Merged
merged 1 commit into from
May 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion libs/constants/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -152,14 +152,24 @@ export const CSP_DIRECTIVES = {
"wikipedia.org",
"upload.wikimedia.org",

// Shared assets.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Shared assets.

"https://mdn.github.io/shared-assets/",

// GA4.
"https://*.google-analytics.com",
"https://*.googletagmanager.com",

"www.gstatic.com",
],
"manifest-src": ["'self'"],
"media-src": ["'self'", "archive.org", "videos.cdn.mozilla.net"],
"media-src": [
"'self'",
"archive.org",
"videos.cdn.mozilla.net",

// Shared assets.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Shared assets.

"https://mdn.github.io/shared-assets/",
],
"child-src": ["'self'"],
"worker-src": ["'self'"],
};
Expand Down
Loading