-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(csp): allow shared assets #10858
Conversation
Allow assers from https://mdn.github.io/shared-assets/ managed via GitHub pages in https://github.com/mdn/shared-assets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we need those comments, but otherwise LGTM. 👍
@@ -152,14 +152,24 @@ export const CSP_DIRECTIVES = { | |||
"wikipedia.org", | |||
"upload.wikimedia.org", | |||
|
|||
// Shared assets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Shared assets. |
"archive.org", | ||
"videos.cdn.mozilla.net", | ||
|
||
// Shared assets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Shared assets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Merging now, ty! |
Summary
Allow assers from https://mdn.github.io/shared-assets/ managed via GitHub pages in https://github.com/mdn/shared-assets