Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(csp): allow shared assets #10858

Merged
merged 1 commit into from
May 13, 2024
Merged

feat(csp): allow shared assets #10858

merged 1 commit into from
May 13, 2024

Conversation

fiji-flo
Copy link
Contributor

@fiji-flo fiji-flo commented Apr 5, 2024

Summary

Allow assers from https://mdn.github.io/shared-assets/ managed via GitHub pages in https://github.com/mdn/shared-assets

@fiji-flo fiji-flo requested a review from a team as a code owner April 5, 2024 13:51
@fiji-flo fiji-flo requested a review from bsmth April 5, 2024 13:52
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need those comments, but otherwise LGTM. 👍

@@ -152,14 +152,24 @@ export const CSP_DIRECTIVES = {
"wikipedia.org",
"upload.wikimedia.org",

// Shared assets.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Shared assets.

"archive.org",
"videos.cdn.mozilla.net",

// Shared assets.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Shared assets.

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bsmth
Copy link
Member

bsmth commented May 13, 2024

Merging now, ty!

@bsmth bsmth merged commit 4249546 into main May 13, 2024
12 checks passed
@bsmth bsmth deleted the shared-assets branch May 13, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants