Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ai-help): index short_title #10579

Merged
merged 1 commit into from
Feb 29, 2024
Merged

feat(ai-help): index short_title #10579

merged 1 commit into from
Feb 29, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Feb 23, 2024

Summary

(MP-671)

Problem

MDN contains some pages with identical titles, and these may appear next to each other among the consulted MDN pages, only distinguishable by their corresponding URL.

Solution

Index all pages' short_title so that we can show the parent page's short_title where necessary.


Screenshots

Before

image

After

image


How did you test this change?

Tested locally by asking How can I redirect using HTTP? with mdn/rumba#428.

Notes:

  • Added the title_short column to all three Supabase projects.
  • Manually ran the script for the dev project.
  • Copied title to title_short for stage and prod projects.

@caugner caugner requested a review from a team as a code owner February 23, 2024 15:45
Copy link
Contributor

@argl argl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@caugner caugner merged commit 6939552 into main Feb 29, 2024
12 checks passed
@caugner caugner deleted the ai-help-index-short-title branch February 29, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants