-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ai-help): add parent short_title for duplicate source titles #428
Conversation
See #431 In general my first thought was to solve this in the front-end and just pull the Did we think about just displaying the URL with in the link for duplicates? That would also make the a lot easier. And in this solution we could do two queries instead of a single complex one (as in only get the parent titles if we need them). |
Hm, interesting idea that I hadn't considered. I don't think this is significantly better. The pure front-end implementation is likely more complex than solving this in the backend, and it introduces a dependency on loading the
I'm not quite sure what you mean. From a UX point of view, it's better to show the parent's title than the parent's slug, if that's what you mean. The SQL query isn't that complex and should be fast, since the |
FYI @fiji-flo I cannot re-request a review, since your comment isn't a review comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Distinguish sources with the same title by appending the parent page's short title.
(MP-671)