Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release-please): fix config structure #10412

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jan 30, 2024

Summary

Problem

The previous config fix accidentally added all config options under the packages key.

Solution

Fix the config structure.


How did you test this change?

We'll see once this is merged.

@caugner caugner requested a review from a team as a code owner January 30, 2024 10:37
@caugner
Copy link
Contributor Author

caugner commented Jan 30, 2024

@OnkarRuikar Can you take a look? 🙏

@OnkarRuikar
Copy link
Contributor

OnkarRuikar commented Jan 30, 2024

@caugner ohh, I accidentally put everything under packages. This looks good as per https://github.com/googleapis/release-please/blob/main/release-please-config.json

@caugner
Copy link
Contributor Author

caugner commented Jan 30, 2024

@OnkarRuikar Can you approve the PR? Then I can merge. 😉

@OnkarRuikar
Copy link
Contributor

🤞 You need to close and retrigger the release PR. How did you recreate the last release pr?

@caugner caugner merged commit ac63c63 into main Jan 30, 2024
12 checks passed
@caugner caugner deleted the fix-release-please-config branch January 30, 2024 11:00
@caugner
Copy link
Contributor Author

caugner commented Jan 30, 2024

🤞 You need to close and retrigger the release PR. How did you recreate the last release pr?

release-please automatically runs on pushes to main and it should create or update the release PR: https://github.com/mdn/yari/actions/runs/7710098741/job/21012724255

@OnkarRuikar
Copy link
Contributor

🤞 You need to close and retrigger the release PR. How did you recreate the last release pr?

release-please automatically runs on pushes to main and it should create or update the release PR: https://github.com/mdn/yari/actions/runs/7710098741/job/21012724255

Looks like it worked! ;)
https://github.com/mdn/yari/pull/10407/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants