fix(release-please): move release-type/changelog-sections to config file #10411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OnkarRuikar Thanks, your changes make sense, but this means the release-please-action docs are misleading:
So those advanced options go in the config file, not the manifest file. |
caugner
requested changes
Jan 30, 2024
caugner
approved these changes
Jan 30, 2024
ayushmanchhabra
added a commit
to nwutils/nw-builder
that referenced
this pull request
Feb 12, 2024
Introduced in: #1028 Refs: mdn/yari#10411 Applying the changes from the linked PR, this should work in `main`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix migration to release please v4. Document referred for this: bootstrap manually and config schema
After merging this you'll need to create a new release-pr.
cc @caugner