Demix DocumentOrShadowRoot #9045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
reviewed
Feb 10, 2021
There was a problem hiding this comment.
I have run the collector's update script with all the results we have and commented on non-trivial disagreements. Unfortunately I couldn't make inline suggestions where the relevant bit was outside the diff.
I ignored a bunch of smaller off-by-one issues, which I think we can deal with as updates after this lands.
foolip
reviewed
Feb 10, 2021
|
Thanks, this was really helpful @foolip! It shows real benefits of having mixins treated properly. The data is quite different from interface to interface. |
foolip
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, here we saw quite early version numbers, probably to fix #3504.
I've left those early versions for the Document part here.
For the ShadowRoot part, I've temporarily added a root compat data object api.ShadowRoot to this file, so the consistency checker would complain (it currently doesn't, I filed #9044). I've then bumped the versions up to the basic support of ShadowRoot for all features of ShadowRoot.
I've removed the documentorshadowroot feature from ShadowRoot. It makes no sense with the new mixin approach, imo.
It would be cool if some automation could actually verify the version numbers here, since I want to focus on demixing instead of on researching the correct data for two interfaces. (cc @foolip)