Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency checker doesn't walk the tree (for mixins) #9044

Closed
Elchi3 opened this issue Feb 9, 2021 · 3 comments
Closed

Consistency checker doesn't walk the tree (for mixins) #9044

Elchi3 opened this issue Feb 9, 2021 · 3 comments
Labels
idle Issues and pull requests with no recent activity linter Issues or pull requests regarding the tests / linter of the JSON files.

Comments

@Elchi3
Copy link
Member

Elchi3 commented Feb 9, 2021

I'm working on demixing!

One thing I noticed is that the consistency checker apparently doesn't walk the tree.

Assume you have api/ShadowRoot.json
Basic support (root __compat object, so api.ShadowRoot) says chrome 53.

Now you add to that api.ShadowRoot tree in a file called _mixins/DocumentOrShadowRoot__ShadowRoot.json
And so the tree gets api.ShadowRoot.activeElement and it says chrome 1.

This makes no sense. ShadowRoot sub features can't exist before the ShadowRoot main interface exist. The consistency lint doesn't detect this.

@queengooborg queengooborg added the linter Issues or pull requests regarding the tests / linter of the JSON files. label Feb 9, 2021
@ddbeck
Copy link
Collaborator

ddbeck commented Feb 17, 2021

I don't have a precise solution in mind for this yet, but I think this mostly stems from the fact that our checks run on a per-file basis. We might use this as an opportunity to distinguish between checks on the source (i.e., that it parses and it's formatted correctly), checks on a single feature (or its components—such as note formatting, etc.), and checks against a tree or subtree (i.e., that a tree in a given file or the whole tree is consistent).

@foolip
Copy link
Contributor

foolip commented May 27, 2021

This is a bit of an issue for #10646, where I know there's some lack of consistency introduced, but I don't know how much.

@github-actions github-actions bot added the idle Issues and pull requests with no recent activity label May 25, 2022
@queengooborg
Copy link
Contributor

This was resolved by introducing the next-gen linter in #16437!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Issues and pull requests with no recent activity linter Issues or pull requests regarding the tests / linter of the JSON files.
Projects
None yet
Development

No branches or pull requests

5 participants
@ddbeck @Elchi3 @foolip @queengooborg and others