Skip to content

Commit

Permalink
specification: domains: clarify start and size fields
Browse files Browse the repository at this point in the history
The 'start' and 'size' fields in the 'memory' and 'sram' properties of
the execution domain binding could use a bit of clarification. In
particular, it's not fully specified where the #address-cells and
the #size-cells properties that determine the number of cells used
for these fields come from. Spell it out to be explicit.

Fixes: devicetree-org#162
Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
Reviewed-by: Stefano Stabellini <stefano.stabellini@amd.com>
  • Loading branch information
mbolivar-nordic committed May 10, 2023
1 parent 4d2a98a commit 7b231b9
Showing 1 changed file with 8 additions and 10 deletions.
18 changes: 8 additions & 10 deletions specification/source/chapter3-execution-domains.rst
Original file line number Diff line number Diff line change
Expand Up @@ -224,9 +224,6 @@ Within each pair:
memory Property
~~~~~~~~~~~~~~~

.. FIXME: start and size #cells are unclear:
https://github.com/devicetree-org/lopper/issues/138
.. FIXME: specify content of flags:
https://github.com/devicetree-org/lopper/issues/137
Expand All @@ -249,10 +246,12 @@ Within each triplet:

- *start* is the physical address of the start of the memory range. The
number of cells used to represent the start address is determined by
the *#address-cells* property.
the *#address-cells* property of the parent node of the domain containing
the *memory* property.
- *size* is the size of the memory range, in bytes. The number of cells
used to represent the size is determined by the *#size-cells*
property.
property of the parent node of the domain containing
the *memory* property.
- *flags* contains domain-specific flags. The number of cells in each flag is
defined by the *#memory-flags-cells* property of the execution domain.

Expand Down Expand Up @@ -284,9 +283,6 @@ between two domains.
sram Property
~~~~~~~~~~~~~

.. FIXME: start and size #cells are unclear:
https://github.com/devicetree-org/lopper/issues/138
.. FIXME: specify content of flags:
https://github.com/devicetree-org/lopper/issues/137
Expand All @@ -310,10 +306,12 @@ Within each triplet:

- *start* is the physical address of the start of the memory range. The
number of cells used to represent the start address is determined by
the *#address-cells* property.
the *#address-cells* property of the parent node of the domain containing
the *sram* property.
- *size* is the size of the memory range, in bytes. The number of cells
used to represent the size is determined by the *#size-cells*
property.
property of the parent node of the domain containing
the *sram* property.
- *flags* contains domain-specific flags. The number of cells in each flag is
defined by the *#sram-flags-cells* property of the execution domain.

Expand Down

0 comments on commit 7b231b9

Please sign in to comment.