Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory and sram clarification for #address-cells and #size-cells #162

Open
mbolivar-nordic opened this issue Mar 2, 2023 · 1 comment
Open

Comments

@mbolivar-nordic
Copy link
Contributor

As of 4fc81d4, the memory
property in the "openamp,domain-v1" binding has the following in its
specification:

- *start* is the physical address of the start of the memory range. The
  number of cells used to represent the start address is determined by
  the *#address-cells* property.
- *size* is the size of the memory range, in bytes. The number of cells
  used to represent the size is determined by the *#size-cells*
  property.

There is a similar comment for sram.

In each case, the node that contains the #address-cells and
#size-cells properties is not specified. Which node is it?

@sstabellini
Copy link
Collaborator

I think it should be the #address-cells and #size-cells properties of the parent node.

domains {
	#address-cells = <0x2>;
	#size-cells = <0x2>;

	linux {
		memory = <0x0 0x0 0x1 0x0>

mbolivar-nordic added a commit to mbolivar-nordic/lopper that referenced this issue May 10, 2023
The 'start' and 'size' fields in the 'memory' and 'sram' properties of
the execution domain binding could use a bit of clarification. In
particular, it's not fully specified where the #address-cells and
the #size-cells properties that determine the number of cells used
for these fields come from. Spell it out to be explicit.

Fixes: devicetree-org#162
Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
Reviewed-by: Stefano Stabellini <stefano.stabellini@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants