Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿ [#1608] Setting up focus trap for accordion and mobile menu #708

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Jul 4, 2023

https://taiga.maykinmedia.nl/project/open-inwoner/task/1608

  • make mobile menu the only Tabbable focus, hide everything else
  • make accordion FAQ titles the only focus on Tab key when collapsed/hidden; then again make accordion-panel focusable when answer is open, so user can tab towards links inside the panels.

info: the mobile 'view' will become visible when users zoom in more than 200% - hence why this needs to be accessible with keyboard tabs as well.

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023

Codecov Report

Merging #708 (17c49b2) into develop (c23318e) will not change coverage.
The diff coverage is n/a.

❗ Current head 17c49b2 differs from pull request most recent head f066f40. Consider uploading reports for the commit f066f40 to get more accurate results

@@           Coverage Diff            @@
##           develop     #708   +/-   ##
========================================
  Coverage    96.20%   96.20%           
========================================
  Files          642      642           
  Lines        22934    22934           
========================================
  Hits         22064    22064           
  Misses         870      870           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jiromaykin jiromaykin force-pushed the fix/1608-A11y-2.4.7AA-focus-visibility-nav-faq branch from 48d190a to beaa2ad Compare July 4, 2023 14:23
@jiromaykin jiromaykin marked this pull request as ready for review July 4, 2023 14:24
@jiromaykin jiromaykin force-pushed the fix/1608-A11y-2.4.7AA-focus-visibility-nav-faq branch from 17c49b2 to f066f40 Compare July 6, 2023 09:03
@jiromaykin jiromaykin requested a review from pi-sigma July 6, 2023 12:36
@pi-sigma pi-sigma merged commit 0d5fb32 into develop Jul 10, 2023
@pi-sigma pi-sigma deleted the fix/1608-A11y-2.4.7AA-focus-visibility-nav-faq branch July 10, 2023 09:14
@jiromaykin jiromaykin added the Accessibility Improving accessibility label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Improving accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants