Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3021] Catch API errors when fetching related questions #1608

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

swrichards
Copy link
Collaborator

@swrichards swrichards commented Feb 6, 2025

@swrichards swrichards marked this pull request as ready for review February 6, 2025 17:03
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 94.22%. Comparing base (ba5599e) to head (f89e82b).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
src/open_inwoner/accounts/views/contactmoments.py 60.00% 4 Missing ⚠️
src/open_inwoner/cms/cases/views/status.py 60.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1608      +/-   ##
===========================================
- Coverage    94.24%   94.22%   -0.02%     
===========================================
  Files         1080     1080              
  Lines        39874    39886      +12     
===========================================
+ Hits         37578    37582       +4     
- Misses        2296     2304       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swrichards swrichards requested a review from alextreme February 6, 2025 17:28
@swrichards swrichards force-pushed the issues/3021-error-handling-ok2-questions branch from 932aa03 to f89e82b Compare February 6, 2025 17:33
@swrichards swrichards merged commit 307ebbc into develop Feb 6, 2025
21 checks passed
@swrichards swrichards deleted the issues/3021-error-handling-ok2-questions branch February 6, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants