[#1452] Added middleware to hide django-cms toolbar when not 2FA verified #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bartvaderkin
commented
May 15, 2023
Comment on lines
+37
to
+39
| request.session["cms_edit"] = False | ||
| request.session["cms_preview"] = False | ||
| request.session["cms_toolbar_disabled"] = True |
There was a problem hiding this comment.
We might not even need these but the CMS code is really messy in when/where is looks into these so I'd just clobber them before setting the most important toolbar.show_toolbar = False
Codecov Report
@@ Coverage Diff @@
## develop #618 +/- ##
===========================================
- Coverage 96.50% 96.48% -0.03%
===========================================
Files 598 598
Lines 20545 20563 +18
===========================================
+ Hits 19827 19840 +13
- Misses 718 723 +5
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alextreme
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried a bunch of approaches, like putfing an if/else around the template tag, extending the regular ToolbarMiddleware, extending the template tag and some others, but this is the simplest that doesn't break anything.
It seems to work in browser, if it is acceptable I'll figure out how to create a test for this tomorrow.