-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2821] Implement provisional configuration for OpenKlant2 service #1452
Conversation
eea4282
to
ac0385b
Compare
2a144b4
to
76c93ec
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1452 +/- ##
========================================
Coverage 94.59% 94.59%
========================================
Files 1062 1063 +1
Lines 39651 39715 +64
========================================
+ Hits 37507 37569 +62
- Misses 2144 2146 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, TLDR: let's try to not touch the openklant2
module at all if we can help it (except for the naming improvements you made in the client constructor).
76c93ec
to
086aa0b
Compare
3402ea1
to
8968133
Compare
8968133
to
d4965e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as we use the Services for the actual configuration later on, this is fine for now
That's indeed the idea (#1472 is a next step that in direction). |
The PR adds a provisional configuration for the OpenKlant2 service + tests so we can start integrating OpenKlant2 into our code. To be replaced with a proper configuration model.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2821