Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2821] Implement provisional configuration for OpenKlant2 service #1452

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Oct 18, 2024

The PR adds a provisional configuration for the OpenKlant2 service + tests so we can start integrating OpenKlant2 into our code. To be replaced with a proper configuration model.

Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2821

@pi-sigma pi-sigma force-pushed the task/2821-openklant2-config branch from eea4282 to ac0385b Compare October 18, 2024 12:55
@pi-sigma pi-sigma changed the title [#2821] Implement provisionary configuration for OpenKlant2 service [#2821] Implement provisional configuration for OpenKlant2 service Oct 18, 2024
@pi-sigma pi-sigma force-pushed the task/2821-openklant2-config branch 2 times, most recently from 2a144b4 to 76c93ec Compare October 18, 2024 13:49
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.59%. Comparing base (0862012) to head (d4965e0).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
src/open_inwoner/openklant/models.py 85.71% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1452   +/-   ##
========================================
  Coverage    94.59%   94.59%           
========================================
  Files         1062     1063    +1     
  Lines        39651    39715   +64     
========================================
+ Hits         37507    37569   +62     
- Misses        2144     2146    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma marked this pull request as ready for review October 18, 2024 14:11
@pi-sigma pi-sigma requested a review from swrichards October 18, 2024 14:11
Copy link
Collaborator

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, TLDR: let's try to not touch the openklant2 module at all if we can help it (except for the naming improvements you made in the client constructor).

@pi-sigma pi-sigma force-pushed the task/2821-openklant2-config branch from 76c93ec to 086aa0b Compare October 21, 2024 13:01
@pi-sigma pi-sigma marked this pull request as draft October 21, 2024 13:01
@pi-sigma pi-sigma marked this pull request as ready for review October 22, 2024 07:27
@pi-sigma pi-sigma requested a review from swrichards October 22, 2024 07:28
@pi-sigma pi-sigma force-pushed the task/2821-openklant2-config branch 2 times, most recently from 3402ea1 to 8968133 Compare October 22, 2024 09:02
@swrichards swrichards force-pushed the task/2821-openklant2-config branch from 8968133 to d4965e0 Compare October 24, 2024 08:47
@swrichards swrichards self-requested a review October 24, 2024 11:57
Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we use the Services for the actual configuration later on, this is fine for now

@alextreme alextreme merged commit a6bb96b into develop Oct 24, 2024
20 checks passed
@alextreme alextreme deleted the task/2821-openklant2-config branch October 24, 2024 16:28
@swrichards
Copy link
Collaborator

As long as we use the Services for the actual configuration later on, this is fine for now

That's indeed the idea (#1472 is a next step that in direction).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants