✨ #481 - Handle situation where the user has been made inact…" #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… been made inact…""
svenvandescheur
approved these changes
May 9, 2022
annashamray
requested changes
May 9, 2022
There was a problem hiding this comment.
I think that
disabledparam is excessive on the form level: because it the whole form is inactive when why to show itdisabledparam is excessive for the form_action component for the same reason
To be honest I don't understand why to show the form on the message page if the user is inactive?
Let's just remove it from the page without propagating disabled parameter through several components
Also some testing would be appreciated
src/open_inwoner/accounts/forms.py
Outdated
| @@ -245,6 +245,10 @@ def __init__(self, user, **kwargs): | |||
| self.fields["receiver"].choices = choices | |||
| self.fields["receiver"].queryset = extended_contact_users | |||
|
|
|||
| if disabled: | |||
| self.fields["content"].disabled = True | |||
| self.fields["content"].widget.attrs["placeholder"] = _("Gebruiker inactief") | |||
There was a problem hiding this comment.
file field is not disabled
7ca165b to
fe5b114
Compare
annashamray
approved these changes
May 27, 2022
There was a problem hiding this comment.
I've removed "disabled" parameter from form and form actions.
@JostCrow if it should be present please revert my commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restoring PR for 211