✨ #391 - Allow description to be shown by a file. #207
Conversation
|
|
6438b1a to
67618f2
Compare
|
|
|
|
|
|
|
|
|
|
|
|
79c015b to
1f4c7ab
Compare
|
|
| @@ -134,6 +134,9 @@ def get(self, request, *args, **kwargs): | |||
| """Mark all messages as seen for the receiver""" | |||
| context = self.get_context_data() | |||
|
|
|||
| if not request.GET.get("redirected"): | |||
There was a problem hiding this comment.
Maybe add a comment why this is added. This is not clear to me
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
To move to then end of the conversation
There was a problem hiding this comment.
That would be a usefull comment. So that we know why the redirect should stay there
src/open_inwoner/templates/pages/questionnaire/questionnaire-step.html
Outdated
Show resolved
Hide resolved
…ted for a digid certification.
e3370a9 to
3a31497
Compare
84e1d95 to
3b9728e
Compare
| @@ -134,6 +134,9 @@ def get(self, request, *args, **kwargs): | |||
| """Mark all messages as seen for the receiver""" | |||
| context = self.get_context_data() | |||
|
|
|||
| if not request.GET.get("redirected"): | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
3b9728e to
33c5020
Compare
|
Taiga 445 is something Anna is working on and can be done separately @JostCrow and @annashamray please discuss this PR and if it needs further work. After the Actions Anna can continue with the Messages |
|
One of my issues is still open of the missing comment. Since that will help with maintenance later on and the conflict that needs to be fixed. If the 2 open issues are solved in other pull requests that will be fine and that comment can be disregarded. |
|
I noticed that a comment was already added when viewing the PR. Sven is on a holiday this week, this is the reason I've gotten involved. |
|
Yes, but the comment is not clear enough. Because I did not know how it is now in the code that is is supposed to scroll down to the latest message in the conversation |
|
PR is for Jorik to approve/decline imho |
Can be populated by filling in the description field on the filer file.