Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2996] Create questions with OpenKlant linked to a zaak #1593

Merged
merged 2 commits into from
Feb 5, 2025
Merged

[#2996] Create questions with OpenKlant linked to a zaak #1593

merged 2 commits into from
Feb 5, 2025

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Jan 30, 2025 •
edited
Loading

@pi-sigma pi-sigma force-pushed the task/2996-openklant-zaak-questions branch from 09657a5 to ed0569b Compare January 30, 2025 16:47
@pi-sigma pi-sigma changed the title Task/2996 openklant zaak questions [#2996] Create questiosn with openklant linked to a zaak Jan 30, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.86364% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.24%. Comparing base (0c83d98) to head (9d4ea40).

Files with missing lines Patch % Lines
src/open_inwoner/openklant/services.py 92.30% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1593      +/-   ##
===========================================
+ Coverage    94.20%   94.24%   +0.03%     
===========================================
  Files         1080     1080              
  Lines        39790    39865      +75     
===========================================
+ Hits         37483    37569      +86     
+ Misses        2307     2296      -11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma changed the title [#2996] Create questiosn with openklant linked to a zaak [#2996] Create questions with openklant linked to a zaak Jan 31, 2025
@pi-sigma pi-sigma marked this pull request as ready for review January 31, 2025 07:22
@pi-sigma pi-sigma requested a review from swrichards January 31, 2025 07:22
@pi-sigma pi-sigma force-pushed the task/2996-openklant-zaak-questions branch 3 times, most recently from a6d8b4a to f8f466d Compare January 31, 2025 15:06
@pi-sigma pi-sigma marked this pull request as draft February 4, 2025 13:22
@pi-sigma pi-sigma force-pushed the task/2996-openklant-zaak-questions branch 4 times, most recently from ac7bf00 to 5779ec4 Compare February 5, 2025 10:15
@pi-sigma pi-sigma marked this pull request as ready for review February 5, 2025 10:41
swrichards
swrichards requested changes Feb 5, 2025
View reviewed changes
@pi-sigma pi-sigma force-pushed the task/2996-openklant-zaak-questions branch from 5779ec4 to 214fc45 Compare February 5, 2025 14:07
@pi-sigma pi-sigma changed the title [#2996] Create questions with openklant linked to a zaak [#2996] Create questions with OpenKlant linked to a zaak Feb 5, 2025
@pi-sigma pi-sigma requested a review from swrichards February 5, 2025 14:37
@pi-sigma pi-sigma force-pushed the task/2996-openklant-zaak-questions branch from 214fc45 to 9d4ea40 Compare February 5, 2025 15:27
@swrichards swrichards merged commit c1139a3 into develop Feb 5, 2025
22 checks passed
@swrichards swrichards deleted the task/2996-openklant-zaak-questions branch February 5, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swrichards swrichards swrichards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pi-sigma @codecov-commenter @swrichards