Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2969] Create questions with OpenKlant2 #1574

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma force-pushed the task/2969-openklant2-vragen branch 2 times, most recently from 445cac7 to 1a11da2 Compare January 23, 2025 10:41
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 95.95960% with 8 lines in your changes missing coverage. Please review.

Project coverage is 94.19%. Comparing base (a6d78fa) to head (4352a67).

Files with missing lines Patch % Lines
src/open_inwoner/openklant/services.py 71.42% 4 Missing ⚠️
src/open_inwoner/accounts/signals.py 86.66% 2 Missing ⚠️
src/open_inwoner/openklant/admin.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1574      +/-   ##
===========================================
- Coverage    94.20%   94.19%   -0.01%     
===========================================
  Files         1079     1080       +1     
  Lines        39646    39773     +127     
===========================================
+ Hits         37347    37466     +119     
- Misses        2299     2307       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma force-pushed the task/2969-openklant2-vragen branch 6 times, most recently from 67c7aca to a26465c Compare January 29, 2025 16:01
@pi-sigma pi-sigma marked this pull request as ready for review January 29, 2025 16:30
@pi-sigma pi-sigma requested a review from swrichards January 29, 2025 16:30
Copy link
Collaborator

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question about the anonymous user/ok2 configuration, otherwise just nitpicks.

@pi-sigma pi-sigma force-pushed the task/2969-openklant2-vragen branch from a26465c to dd1133a Compare February 4, 2025 11:21
@pi-sigma pi-sigma marked this pull request as draft February 4, 2025 11:21
@pi-sigma pi-sigma force-pushed the task/2969-openklant2-vragen branch 2 times, most recently from 0cc6bb6 to 92d3984 Compare February 4, 2025 12:02
@pi-sigma pi-sigma marked this pull request as ready for review February 4, 2025 13:01
@pi-sigma pi-sigma force-pushed the task/2969-openklant2-vragen branch from 92d3984 to ff4f04a Compare February 4, 2025 13:03
@pi-sigma pi-sigma requested a review from swrichards February 4, 2025 13:08
Copy link
Collaborator

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nitpicks now, all to do with handling the (far-fetched) case in which we add something to the service enum but forget to handle it in all our getters, otherwise LGTM.

@pi-sigma pi-sigma marked this pull request as draft February 4, 2025 15:47
@pi-sigma pi-sigma force-pushed the task/2969-openklant2-vragen branch from ff4f04a to bfbe2ae Compare February 4, 2025 16:03
@pi-sigma pi-sigma marked this pull request as ready for review February 4, 2025 16:04
@pi-sigma pi-sigma marked this pull request as draft February 5, 2025 07:49
@pi-sigma pi-sigma force-pushed the task/2969-openklant2-vragen branch from bfbe2ae to c23c143 Compare February 5, 2025 08:09
@pi-sigma pi-sigma force-pushed the task/2969-openklant2-vragen branch from c23c143 to 4352a67 Compare February 5, 2025 08:12
@pi-sigma pi-sigma marked this pull request as ready for review February 5, 2025 08:37
@swrichards swrichards merged commit ff61863 into develop Feb 5, 2025
22 checks passed
@swrichards swrichards deleted the task/2969-openklant2-vragen branch February 5, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants