-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2969] Create questions with OpenKlant2 #1574
Conversation
445cac7
to
1a11da2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1574 +/- ##
===========================================
- Coverage 94.20% 94.19% -0.01%
===========================================
Files 1079 1080 +1
Lines 39646 39773 +127
===========================================
+ Hits 37347 37466 +119
- Misses 2299 2307 +8 ☔ View full report in Codecov by Sentry. |
67c7aca
to
a26465c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question about the anonymous user/ok2 configuration, otherwise just nitpicks.
a26465c
to
dd1133a
Compare
0cc6bb6
to
92d3984
Compare
92d3984
to
ff4f04a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor nitpicks now, all to do with handling the (far-fetched) case in which we add something to the service enum but forget to handle it in all our getters, otherwise LGTM.
ff4f04a
to
bfbe2ae
Compare
bfbe2ae
to
c23c143
Compare
c23c143
to
4352a67
Compare
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2969