-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2862] Integrate OpenKlant2 service with detail views #1490
Conversation
8111c9d
to
606a820
Compare
b838099
to
a3e2396
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1490 +/- ##
========================================
Coverage 94.30% 94.31%
========================================
Files 1067 1068 +1
Lines 40306 40385 +79
========================================
+ Hits 38012 38088 +76
- Misses 2294 2297 +3 ☔ View full report in Codecov by Sentry. |
9b1491f
to
26b9d81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, big push here. Mostly small'ish comments.
d833895
to
44d235b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one or two nitpicks, and the outstanding issue about integrating the seen status into the service.
44d235b
to
dd6fc82
Compare
Can be merged after rebase from Paul and final check |
dd6fc82
to
96fb5c0
Compare
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2862