Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2862] Integrate OpenKlant2 service with detail views #1490

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Nov 7, 2024

@pi-sigma pi-sigma force-pushed the task/2862-openklant2-detail-view branch 2 times, most recently from 8111c9d to 606a820 Compare November 7, 2024 14:53
@pi-sigma pi-sigma changed the title [#2862] Integrate OpenKlant2 service with contactmoment detail view [#2862] Integrate OpenKlant2 service with detail views Nov 7, 2024
@pi-sigma pi-sigma force-pushed the task/2862-openklant2-detail-view branch 5 times, most recently from b838099 to a3e2396 Compare November 12, 2024 14:06
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 91.08911% with 18 lines in your changes missing coverage. Please review.

Project coverage is 94.31%. Comparing base (0b700d3) to head (96fb5c0).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/open_inwoner/openklant/services.py 67.50% 13 Missing ⚠️
src/open_inwoner/accounts/views/contactmoments.py 83.33% 3 Missing ⚠️
src/open_inwoner/cms/cases/views/status.py 92.59% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1490   +/-   ##
========================================
  Coverage    94.30%   94.31%           
========================================
  Files         1067     1068    +1     
  Lines        40306    40385   +79     
========================================
+ Hits         38012    38088   +76     
- Misses        2294     2297    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma force-pushed the task/2862-openklant2-detail-view branch 4 times, most recently from 9b1491f to 26b9d81 Compare November 14, 2024 10:47
@pi-sigma pi-sigma marked this pull request as ready for review November 14, 2024 11:21
@pi-sigma pi-sigma requested a review from swrichards November 14, 2024 11:21
Copy link
Collaborator

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, big push here. Mostly small'ish comments.

@pi-sigma pi-sigma force-pushed the task/2862-openklant2-detail-view branch 6 times, most recently from d833895 to 44d235b Compare November 22, 2024 13:17
@pi-sigma pi-sigma requested a review from swrichards November 22, 2024 14:15
Copy link
Collaborator

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one or two nitpicks, and the outstanding issue about integrating the seen status into the service.

@pi-sigma pi-sigma force-pushed the task/2862-openklant2-detail-view branch from 44d235b to dd6fc82 Compare November 25, 2024 14:38
@alextreme
Copy link
Member

Can be merged after rebase from Paul and final check

@pi-sigma pi-sigma force-pushed the task/2862-openklant2-detail-view branch from dd6fc82 to 96fb5c0 Compare November 28, 2024 15:48
@swrichards swrichards self-requested a review November 28, 2024 16:43
@alextreme alextreme merged commit 0d82080 into develop Nov 28, 2024
20 checks passed
@alextreme alextreme deleted the task/2862-openklant2-detail-view branch November 28, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants