Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2633] Unable to add contactmoment to active cases #1319

Merged

Conversation

swrichards
Copy link
Collaborator

@swrichards swrichards commented Jul 23, 2024

Taiga 2633.

Looks like we missed an indent typo in #1277 -- the create_objectcontactmoment client method always returns None, not only on error cases.

We also forgot to add a None check on associating the case, which is also fixed in this PR.

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.13%. Comparing base (f312d13) to head (97aa09e).

Files Patch % Lines
src/open_inwoner/cms/cases/views/status.py 50.00% 3 Missing ⚠️
src/open_inwoner/openklant/clients.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1319      +/-   ##
===========================================
- Coverage    95.13%   95.13%   -0.01%     
===========================================
  Files          991      991              
  Lines        35886    35889       +3     
===========================================
+ Hits         34141    34143       +2     
- Misses        1745     1746       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swrichards swrichards requested a review from pi-sigma July 23, 2024 11:31
@swrichards swrichards marked this pull request as ready for review July 23, 2024 11:31
@swrichards swrichards merged commit 84a27e8 into develop Jul 24, 2024
18 checks passed
@swrichards swrichards deleted the issue/2633-cannot-create-contactmoment-related-to-zaak branch July 24, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants