Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2580] Link questions with cases #1277

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma force-pushed the task/2580-esuite-case-question-link branch 3 times, most recently from 516b897 to 2907595 Compare June 26, 2024 07:40
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 16 lines in your changes missing coverage. Please review.

Project coverage is 44.21%. Comparing base (318aed7) to head (d89258c).

Files Patch % Lines
src/open_inwoner/openklant/clients.py 14.28% 6 Missing ⚠️
...c/open_inwoner/cms/cases/tests/test_contactform.py 0.00% 4 Missing ⚠️
src/open_inwoner/cms/cases/views/status.py 0.00% 4 Missing ⚠️
src/open_inwoner/cms/cases/tests/test_htmx.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1277      +/-   ##
===========================================
- Coverage    44.22%   44.21%   -0.02%     
===========================================
  Files          972      972              
  Lines        35571    35586      +15     
===========================================
+ Hits         15733    15734       +1     
- Misses       19838    19852      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma marked this pull request as ready for review June 26, 2024 08:32
@pi-sigma pi-sigma requested a review from swrichards June 26, 2024 08:32
@pi-sigma pi-sigma force-pushed the task/2580-esuite-case-question-link branch from 2907595 to 09f05e0 Compare June 26, 2024 12:12
@pi-sigma pi-sigma requested a review from swrichards July 1, 2024 06:44
    - when a contactmoment is created for a given zaak, we need to create
      an objectcontactmoment as well to link the two
@pi-sigma pi-sigma force-pushed the task/2580-esuite-case-question-link branch from 09f05e0 to d89258c Compare July 1, 2024 10:11
@pi-sigma pi-sigma requested a review from swrichards July 1, 2024 10:12
@alextreme alextreme merged commit f131030 into develop Jul 2, 2024
17 checks passed
@alextreme alextreme deleted the task/2580-esuite-case-question-link branch July 2, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants