Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-329] Fix issue of not able to access post button while navigating using tab #352

Merged
merged 1 commit into from
May 6, 2024

Conversation

ayusht2810
Copy link
Contributor

Summary

  • Fixed the issue of user not able to navigate post button when given option to Create New Meeting or Join Existing Meeting

Ticket Link

#68

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.47%. Comparing base (7fa5345) to head (180145c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #352   +/-   ##
=======================================
  Coverage   18.47%   18.47%           
=======================================
  Files           9        9           
  Lines        1510     1510           
=======================================
  Hits          279      279           
  Misses       1180     1180           
  Partials       51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ayusht2810 ayusht2810 added 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core committer labels Mar 29, 2024
Copy link
Contributor

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR above has been tested for the conditions below:-

  • User is able to navigate to the create new meeting and Join existing meeting in the meeting post.

The PR was working well for the above condition, LGTM. Approved.

Note:- The PR has been tested on MM version 8.0.0 and 9.4.0, since the PR was not working on minimum supported version.

@ayusht2810
Copy link
Contributor Author

@mickmister should we merge the above PR?

@Kshitij-Katiyar Kshitij-Katiyar merged commit 0498a0a into master May 6, 2024
11 checks passed
@Kshitij-Katiyar Kshitij-Katiyar deleted the MM-329 branch May 6, 2024 13:25
@mickmister mickmister added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels May 7, 2024
@raghavaggarwal2308 raghavaggarwal2308 added this to the v1.9.0 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Screen reader support for cases where the Zoom post shows a meeting has already been created
5 participants