Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Screen reader support for cases where the Zoom post shows a meeting has already been created #68

Closed
DHaussermann opened this issue Jan 28, 2020 · 9 comments · Fixed by #352
Assignees
Labels
Difficulty/1:Easy Easy ticket Hacktoberfest Help Wanted Community help wanted Tech/ReactJS Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers
Milestone

Comments

@DHaussermann
Copy link

A change was made to add Aria label to the Start Zoom Meeting button here #61

We should also support case where the zoom post is different to inform users that a meeting was created recently. Currently the info about another user having created a meeting is not read out to the user and the "Create New Meeting" button is skipped over.

ZoomMeeting-Mutiple

@jfrerich jfrerich added Help Wanted Community help wanted and removed Triage labels Feb 11, 2020
@hanzei hanzei added Difficulty/1:Easy Easy ticket Tech/ReactJS Up For Grabs Ready for help from the community. Removed when someone volunteers labels Mar 7, 2020
@hanzei hanzei added the Type/Enhancement New feature or improvement of existing feature label Mar 7, 2020
@bolariin
Copy link
Contributor

bolariin commented Aug 2, 2020

I would like to work on this. I was able to recreate the issue with the "Create new meeting" button getting skipped. When I used a screen reader, it read out that another meeting had been created recently on that channel.

info about another user having created a meeting is not read out to the user

I would like to know if this is still an issue

@larkox
Copy link
Contributor

larkox commented Aug 3, 2020

@DHaussermann Can you take a look to this?

@raghavaggarwal2308
Copy link
Contributor

@mickmister @DHaussermann I used this chrome extension to reproduce this issue.

  • It was reading out the "already created a meeting...." message correctly and was treating the rest as an attachment. (The same behavior is observed for the "Join Meeting" post)
  • When I specifically clicked on the attachment, it was reading out the contents of that correctly.

Can you please explain what exactly needs to be done on this issue?

@avas27JTG avas27JTG added this to the next milestone milestone Nov 29, 2023
@mickmister
Copy link
Contributor

@raghavaggarwal2308 It seems this may already been implemented correctly then. @DHaussermann Thoughts on if this ticket is still valid or not?

@raghavaggarwal2308
Copy link
Contributor

@raghavaggarwal2308 It seems this may already been implemented correctly then. @DHaussermann Thoughts on if this ticket is still valid or not?

@DHaussermann Gentle reminder for this

@raghavaggarwal2308
Copy link
Contributor

raghavaggarwal2308 commented Feb 19, 2024

@DHaussermann Gentle reminder

1 similar comment
@raghavaggarwal2308
Copy link
Contributor

@DHaussermann Gentle reminder

@DHaussermann
Copy link
Author

Hi @raghavaggarwal2308,
Sorry for the delay. Yes I believe this is still occurring. Note that the concern here is with JAWS and may not be relevant to other OS level screen readers. That said, I reproduced the issue today on Community with the Zoom plugin running there.

JAWS is skipping the Create New Meeting button.

Jaws

NOTE: I don't think this is technically a screen reader issue. Even without JAWS running I can see which button takes focus when I hit tab and the button is getting skipped (0/5 maybe issue with tab index assigned).

Steps:

  • Get a Windows machine and install JAWS
  • Launch JAWS and run in free 40 minute mode
  • Open Chrome and navigate to a Mattermost instance were Zoom is running and you can connect your account
  • Start a meeting then try to start another one immediately after to get the "Meeting collision"
  • Try tabbing to the Create New Meeting button
    Observed this get's skipped in the tab order.

@ayusht2810
Copy link
Contributor

@DHaussermann created a PR which fixes the issue of not being able to navigate to button using tab. Please let me know if I have to setup JAWS and test that flow as well, or if it is sufficient to have this navigation fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/1:Easy Easy ticket Hacktoberfest Help Wanted Community help wanted Tech/ReactJS Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet