Fixed a nil pointer panic on empty Fields.Priority in new issues #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonblais
approved these changes
Mar 12, 2019
crspeller
approved these changes
Mar 12, 2019
levb
added a commit
that referenced
this pull request
Aug 10, 2020
* iterate through instances when printing out the channel subscriptions update tests for new printing output format don't require --intance for subscribelist * Update tests * shorten field name * several PR feedback fixes * remove unused variable rename map variable * Disconnect users on instance uninstall (#41) * [GH-4] add EE license check (#22) * restrict plugin activation based on license * run go mod tidy -v * wip * add enterprise package * rename license naming to enterprise if user does not have enterprise license, check number of instances installed before allowed to install another cloud or server instance * remove function * fix review feedback * Add license checking tests * wip * wip by Lev * wip * wip * remove comments * remove function to return pointer to true bool value * getMockInstanceStoreKV(0) should return initialized empty store was returning instance store with one instance correct all occurences call of getMockInstanceStoreKV(0) to call with 1 instanance. This fixes many failing tests Add tests for InstallInstance function with extensive license checking * fix linting Co-authored-by: Lev Brouk <lev@mattermost.com> * Fixed #31, #33 (#54) - Use plugin URL as the "home" for app links - Added extra logging for suspicious callbacks - Use templates for `/jira instance install` output * Fix test (#64) * GH-21 Fixed websocket update on user disconnect, instance uninstall (#61) * Fixed websocket update on user disconnect * Revert "Fixed websocket update on user disconnect" This reverts commit 84ca4b27ca2a3ed55408bf359786b3162dc1b29a. * Fixed empty set refresh, defaulting in commands * fixed instance status update * GH-49: Fixed webhook, transition commands (#67) * Use connectInstances array for userConnected redux selector (#71) * Use connectInstances array for userConnected redux selector * add null check * [GH-45] Make sure frontend has up-to-date default instance data (#65) * fetch instances on modal open * Fix errors regarding redux update and missing channelId prop * Get instances when subscribe modal opens * fix tests * Handle case where default instance value in frontend is stale (uninstalled) * Make if statement more safe * Make if statement more safe * fix test * lint * GH-60: Fixed multi-work command alias parsing in webapp (#72) * Fixed --instance Co-authored-by: Lev <1187448+levb@users.noreply.github.com> Co-authored-by: Lev Brouk <lev@mattermost.com> Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
mickmister
pushed a commit
that referenced
this pull request
Jan 18, 2024
* [MI-2608]: Explained the jira subscription modal in the doc. (#31) * [MI-2608]: Explained the jira subscription modal in the doc. * [MI-2608]:Review fixes done 1. Modified the doc 2. Connected the doc from frontend * [MI-2608]: Review fixes done 1. Modified the administrator guide doc * Fixed CI errors * [MI-2698]: Review fixes done of PR #904 (#33) * [MI-2698]: Review fixes done of PR #904 * [MI-2698]: Review fixes done 1. Improved the content of a administrative guide doc * [MI-2799]: Done review fixes of Jira PR #904 (#38) * Fixed CI errrors * [MM-830] Remove extra file * [MM-830] Update snapshot * [MM-830] Remove extra parameter from link * [MM-830] Update snapshot --------- Co-authored-by: ayusht2810 <ayush.thakur@brightscout.com> Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was overlooked in #22
I verified that all pointer fields of Webhook are nil-checked now.
This has been deployed to community-daily, and now new issues are displayed.