[GH-830]: Explained the jira subscription modal in the doc #904

Nityanand13 · 2023-01-24T11:55:29Z

Summary

Explained the way to create and use the Jira subscription modal.
Linked to the docs from the frontend

Ticket Link

Issue: #830

* [MI-2608]: Explained the jira subscription modal in the doc. * [MI-2608]:Review fixes done 1. Modified the doc 2. Connected the doc from frontend * [MI-2608]: Review fixes done 1. Modified the administrator guide doc

mattermost-build · 2023-01-24T11:55:33Z

Hello @Nityanand13,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mickmister · 2023-01-24T16:55:39Z

docs/administrator-guide/notification-management.md

+6. To be more specific, you can add filters as well. You can either include or exclude the particular filter by adding its type or name. For now, we have 3 types of filters :
+   * Epic Link
+   * Labels
+   * Priority


For now, we have 3 types of filters :

There many other filter fields available, including custom fields. As mentioned in #583, "Basically all of them except date pickers." I know that Status is also not currently supported.

What fields have you tried to use that are not available in the feature?

@mickmister
After exploring now I am getting total of 10 types of filters:

Affects versions

Epic Link

Fix versions

Labels

Priority

And a few custom fields as well.

Checkboxes

Labels

Radio Buttons

Select List (multiple choices)

Select List (single choice)

webapp/src/utils/styles.ts

* [MI-2698]: Review fixes done of PR mattermost#904 * [MI-2698]: Review fixes done 1. Improved the content of a administrative guide doc

mattermost-build · 2023-02-17T01:02:02Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

docs/administrator-guide/notification-management.md

mickmister

@Nityanand13 For some reason GitHub won't let me edit the files in the PR. Can you please update with these changes?

codecov-commenter · 2023-02-22T06:50:49Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (249614e) 33.32% compared to head (3bd1923) 33.29%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
- Coverage   33.32%   33.29%   -0.03%     
==========================================
  Files          53       53              
  Lines        7944     7944              
==========================================
- Hits         2647     2645       -2     
- Misses       5070     5072       +2     
  Partials      227      227

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Nityanand13 · 2023-02-22T06:53:31Z

@Nityanand13 For some reason GitHub won't let me edit the files in the PR. Can you please update with these changes?

Sure @mickmister I have updated these changes.

mattermost-build · 2023-03-05T01:02:13Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

hanzei · 2023-09-01T10:03:57Z

@Nityanand13 Would you please merge master into your PR?

mattermost-build · 2023-09-12T01:02:53Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

hanzei · 2023-09-27T09:51:38Z

@Nityanand13 Gentle reminder

… into MM-830

ayusht2810 · 2024-01-04T09:02:23Z

@hanzei resolved the conflicts.

...omponents/modals/channel_subscriptions/__snapshots__/edit_channel_subscription.test.tsx.snap

ayusht2810 · 2024-01-04T13:21:47Z

@hanzei fixed the review comment. Please re-review

… into MM-830

AayushChaudhary0001

Tested this PR and verified the "Learn more" link to redirect the user to the docs. Approved.

[MI-2608]: Explained the jira subscription modal in the doc. (#31)

53c716c

* [MI-2608]: Explained the jira subscription modal in the doc. * [MI-2608]:Review fixes done 1. Modified the doc 2. Connected the doc from frontend * [MI-2608]: Review fixes done 1. Modified the administrator guide doc

Nityanand13 requested a review from mickmister as a code owner January 24, 2023 11:55

mattermost-build added the Contributor label Jan 24, 2023

javaguirre approved these changes Jan 24, 2023

View reviewed changes

Fixed CI errors

1a86e08

hanzei added the 2: Dev Review Requires review by a core committer label Jan 24, 2023

hanzei linked an issue Jan 24, 2023 that may be closed by this pull request

Jira subscriptions modal needs explanation in the docs #830

Closed

mickmister reviewed Jan 24, 2023

View reviewed changes

webapp/src/utils/styles.ts Outdated Show resolved Hide resolved

Nityanand13 added a commit to Brightscout/mattermost-plugin-jira that referenced this pull request Feb 1, 2023

[MI-2698]: Review fixes done of PR mattermost#904

ccf717f

Nityanand13 mentioned this pull request Feb 1, 2023

[MI-2698]: Review fixes done of PR #904 Brightscout/mattermost-plugin-jira#33

Merged

[MI-2698]: Review fixes done of PR mattermost#904 (#33)

ee99447

* [MI-2698]: Review fixes done of PR mattermost#904 * [MI-2698]: Review fixes done 1. Improved the content of a administrative guide doc

Nityanand13 requested a review from mickmister February 6, 2023 12:30

mattermost-build added the Lifecycle/1:stale label Feb 17, 2023

mickmister approved these changes Feb 20, 2023

View reviewed changes

docs/administrator-guide/notification-management.md Outdated Show resolved Hide resolved

docs/administrator-guide/notification-management.md Outdated Show resolved Hide resolved

mickmister removed 2: Dev Review Requires review by a core committer Lifecycle/1:stale labels Feb 20, 2023

mickmister reviewed Feb 20, 2023

View reviewed changes

hanzei added 2: Dev Review Requires review by a core committer Awaiting Submitter Action Blocked on the author labels Feb 21, 2023

Nityanand13 added a commit to Brightscout/mattermost-plugin-jira that referenced this pull request Feb 21, 2023

[MI-2799]: Done review fixes of Jira PR mattermost#904

895fab9

Nityanand13 mentioned this pull request Feb 21, 2023

[MI-2799]: Done review fixes of Jira PR #904 Brightscout/mattermost-plugin-jira#38

Merged

[MI-2799]: Done review fixes of Jira PR mattermost#904 (#38)

87a7f7f

Fixed CI errrors

b0424bc

mattermost-build added the Lifecycle/1:stale label Mar 5, 2023

hanzei requested review from mickmister and removed request for mickmister September 1, 2023 10:03

hanzei removed the Lifecycle/1:stale label Sep 1, 2023

mattermost-build added the Lifecycle/1:stale label Sep 12, 2023

ayusht2810 added 3 commits January 4, 2024 12:34

Merge branch 'master' of github.com:mattermost/mattermost-plugin-jira…

76661ce

… into MM-830

[MM-830] Remove extra file

9a90b68

[MM-830] Update snapshot

d67e277

hanzei reviewed Jan 4, 2024

View reviewed changes

...omponents/modals/channel_subscriptions/__snapshots__/edit_channel_subscription.test.tsx.snap Outdated Show resolved Hide resolved

ayusht2810 added 2 commits January 4, 2024 18:49

[MM-830] Remove extra parameter from link

e774fc4

[MM-830] Update snapshot

dcf81f8

hanzei approved these changes Jan 4, 2024

View reviewed changes

hanzei requested a review from AayushChaudhary0001 January 4, 2024 13:25

Merge branch 'master' of github.com:mattermost/mattermost-plugin-jira…

3bd1923

… into MM-830

AayushChaudhary0001 approved these changes Jan 9, 2024

View reviewed changes

hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jan 9, 2024

mickmister merged commit ea9ab23 into mattermost:master Jan 18, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GH-830]: Explained the jira subscription modal in the doc #904

[GH-830]: Explained the jira subscription modal in the doc #904

Nityanand13 commented Jan 24, 2023

mattermost-build commented Jan 24, 2023

mickmister Jan 24, 2023

Nityanand13 Jan 30, 2023 •

edited

Loading

mattermost-build commented Feb 17, 2023

mickmister left a comment

codecov-commenter commented Feb 22, 2023 •

edited

Loading

Nityanand13 commented Feb 22, 2023

mattermost-build commented Mar 5, 2023

hanzei commented Sep 1, 2023

mattermost-build commented Sep 12, 2023

hanzei commented Sep 27, 2023

ayusht2810 commented Jan 4, 2024

ayusht2810 commented Jan 4, 2024

AayushChaudhary0001 left a comment

[GH-830]: Explained the jira subscription modal in the doc #904

[GH-830]: Explained the jira subscription modal in the doc #904

Conversation

Nityanand13 commented Jan 24, 2023

Summary

Ticket Link

mattermost-build commented Jan 24, 2023

mickmister Jan 24, 2023

Choose a reason for hiding this comment

Nityanand13 Jan 30, 2023 • edited Loading

Choose a reason for hiding this comment

mattermost-build commented Feb 17, 2023

mickmister left a comment

Choose a reason for hiding this comment

codecov-commenter commented Feb 22, 2023 • edited Loading

Codecov Report

Nityanand13 commented Feb 22, 2023

mattermost-build commented Mar 5, 2023

hanzei commented Sep 1, 2023

mattermost-build commented Sep 12, 2023

hanzei commented Sep 27, 2023

ayusht2810 commented Jan 4, 2024

ayusht2810 commented Jan 4, 2024

AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

Nityanand13 Jan 30, 2023 •

edited

Loading

codecov-commenter commented Feb 22, 2023 •

edited

Loading