-
-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Controller, Television, and Desktop folder icons #2218
Conversation
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
Weird i wonder why the color said null. The svgs are fine I think |
@PKief I think I'll commit the associations for the folder names in the material-icons.json file |
Please add them here: |
Okay @PKief |
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
@PKief Done |
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
@PKief All right |
Okay can we merge now? |
Hi @tj-commits, love this set of new icons! I sent a PR to your fork updating the icons in the same sense: I make them "pixel perfect" to 16x16 and also updated the folder template which have changed a bit since #2226. This is the difference between the two versions (top row are my updates, bottom row are the original ones). You're welcome to grab this changes into your PR if you want :) Cheers! |
@lucas-labs Nice, thanks for doing it. |
fit icons to 16x16 grid
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
Why was there an error |
Oh, sorry. Okay |
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
Done |
Merge SuccessfulThanks for your contribution! 🎉 The changes will be part of the upcoming update on the marketplace. |
Thanks, I've closed it now |
@PKief Okay heres the pull request