Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Controller, Television, and Desktop folder icons #2218

Merged
merged 7 commits into from
Mar 3, 2024

Conversation

tj-commits
Copy link
Contributor

@tj-commits tj-commits commented Feb 7, 2024

@PKief Okay heres the pull request

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@tj-commits
Copy link
Contributor Author

Weird i wonder why the color said null. The svgs are fine I think

@tj-commits
Copy link
Contributor Author

@PKief I think I'll commit the associations for the folder names in the material-icons.json file

@PKief
Copy link
Member

PKief commented Feb 7, 2024

Please also link the folder icons to some folder names if possible. Otherwise the pipeline is not happy

image

@PKief
Copy link
Member

PKief commented Feb 7, 2024

@PKief I think I'll commit the associations for the folder names in the material-icons.json file

Please add them here:
https://github.com/PKief/vscode-material-icon-theme/blob/main/src/icons/folderIcons.ts

@tj-commits
Copy link
Contributor Author

Okay @PKief

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@tj-commits
Copy link
Contributor Author

@PKief Done

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@tj-commits
Copy link
Contributor Author

@PKief All right

@tj-commits tj-commits mentioned this pull request Feb 21, 2024
2 tasks
@tj-commits
Copy link
Contributor Author

Okay can we merge now?

@lucas-labs
Copy link
Member

Hi @tj-commits, love this set of new icons!
Last week PKief merged a PR by me that changed all the folder icons to make them look crispier and "pixel perfect" at 16x16px, which is the default vscode size.

I sent a PR to your fork updating the icons in the same sense: I make them "pixel perfect" to 16x16 and also updated the folder template which have changed a bit since #2226.

This is the difference between the two versions (top row are my updates, bottom row are the original ones).

diff

crispy
burry

You're welcome to grab this changes into your PR if you want :)

Cheers!

@tj-commits
Copy link
Contributor Author

@lucas-labs Nice, thanks for doing it.

fit icons to 16x16 grid
Copy link
Contributor

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@tj-commits
Copy link
Contributor Author

@PKief

Copy link
Contributor

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@tj-commits
Copy link
Contributor Author

Why was there an error

@PKief
Copy link
Member

PKief commented Feb 28, 2024

There's (in folderIcons.ts) one new line too much:

image

Can you please remove it? Then the pipeline will be green.

@tj-commits
Copy link
Contributor Author

Oh, sorry. Okay

Copy link
Contributor

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@tj-commits
Copy link
Contributor Author

Done

@PKief PKief merged commit b0d6a49 into material-extensions:main Mar 3, 2024
4 checks passed
Copy link
Contributor

github-actions bot commented Mar 3, 2024

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the marketplace.

@tj-commits
Copy link
Contributor Author

@PKief Can you close #1821 too? It was the original issue

@PKief
Copy link
Member

PKief commented Mar 3, 2024

Thanks, I've closed it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants