Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon Request] (please read) desktop, television, and console icons #2215

Closed
1 of 2 tasks
tj-commits opened this issue Feb 7, 2024 · 7 comments
Closed
1 of 2 tasks

Comments

@tj-commits
Copy link
Contributor

tj-commits commented Feb 7, 2024

Hi PKief, please read this. My old account was deleted, but basically, I'm the guy who used to answer all the issues and pull requests and stuff. I created these icons already, so I'm just reposting this because I think you forgot.

Credit to @Jdyn for making the original request for these to be added. Here is what he said:

a desktop folder is becoming increasingly common with monorepo tools like turborepo where you commonly house desktop, web, and mobile code in the same repository. 'web' and 'mobile' already have icons and desktop seems highly relevant to support as well.

Icon Type

  • Folder
  • File

Folder Names
for desktop:

  • desktop
    for television:
  • tv
  • television
    for console:
  • console

Graphic ideas

This is all the icons: https://github.com/PKief/vscode-material-icon-theme/files/10420890/Archive.zip

Additional context
Add any other context about the problem here.

@PKief
Copy link
Member

PKief commented Feb 7, 2024

Thanks for letting me know. I was wondering if you could create a PR with the icons?

@PKief
Copy link
Member

PKief commented Feb 7, 2024

And is it necessary to have a separate issue for that? Or can we keep this issue? #1821

@tj-commits
Copy link
Contributor Author

@PKief I'll make a PR. I think you should keep #1821.

@tj-commits
Copy link
Contributor Author

@PKief should this be closed?

@PKief
Copy link
Member

PKief commented Feb 7, 2024

yes

@tj-commits
Copy link
Contributor Author

@PKief I made a PR: #2218

@tj-commits
Copy link
Contributor Author

I didn't add the folder-icon associations I only added the icons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants