Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

chore(infrastructure): Run 2 parallel browsers by default instead of 3 #3500

Merged
merged 1 commit into from
Sep 2, 2018
Merged

chore(infrastructure): Run 2 parallel browsers by default instead of 3 #3500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/screenshot/infra/lib/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ If a local dev server is not already running, one will be started for the durati
type: 'integer',
description: `
Maximum number of browser VMs to run in parallel (subject to our CBT plan limit and VM availability).
If no value is specified, the default is to start 3 browsers if nobody else is running tests, or 1 browser if other
If no value is specified, the default is to start 2 browsers if nobody else is running tests, or 1 browser if other
tests are already running.
IMPORTANT: To ensure that multiple developers can run their tests simultaneously, DO NOT set this value during normal
business hours.
Expand Down
2 changes: 1 addition & 1 deletion test/screenshot/infra/lib/selenium-api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ class SeleniumApi {
// If nobody else is running any tests, run half the number of concurrent tests allowed by our CBT account.
// This gives us _some_ parallelism while still allowing other users to run their tests.
if (active === 0) {
return Math.ceil(max / 2);
return Math.floor(max / 2);
}

// If someone else is already running tests, only run one test at a time.
Expand Down