This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
chore(infrastructure): Run 2 parallel browsers by default instead of 3 #3500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running 3 of 5 parallel browsers is a waste of resources. The tests finish in the same amount of time with 2 parallel browsers, and by only using 2, we free up an extra VM for somebody else to use. As before, the `--parallels=N` CLI flag can be used to override the default.
|
All 357 screenshot tests passed for commit 7f1e764 vs. |
mdc-web-bot
approved these changes
Sep 2, 2018
adrianschmidt
pushed a commit
to Lundalogik/material-components-web
that referenced
this pull request
Sep 25, 2018
material-components#3500) Running 3 parallel browsers is a waste of resources. `npm run screenshot:test` captures screenshots in 4 browsers, so it takes the same amount of time to finish whether it run 2 or 3 browsers in parallel. By only consuming 2 parallels, we free up a VM for someone else to use. As before, the `--parallels=N` CLI flag can be used to override the default. (cherry picked from commit 782cd67)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running 3 parallel browsers is a waste of resources.
npm run screenshot:testcaptures screenshots in 4 browsers, so it takes the same amount of time to finish whether it run 2 or 3 browsers in parallel.By only consuming 2 parallels, we free up a VM for someone else to use.
As before, the
--parallels=NCLI flag can be used to override the default.