New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change endorsements #3004

Merged

damip merged 8 commits into prepare_testnet_15 from change_endorsements

Sep 13, 2022

Contributor

adrien-zinger commented Sep 13, 2022

On processing a slot, select the latest block on the same thread as endorsed block.
Target the current slot to check the endorsements for the best parent.

adrien-zinger added 2 commits

September 12, 2022 17:31


          Quick fix "all features" missing implementation

0187ad1


          Change endorsements logic

61f3c61

We need to PoS-select endorsement creators that are allowed to be included in blocks at slot (period, thread).
The endorsements selected at (period, thread) are created/emitted at time genesis_timestamp + period * t0 + thread * (t0/thread_count) - t0/2 and endorse the latest blockclique (or final) block of their thread.

adrien-zinger self-assigned this

adrien-zinger requested a review from damip

September 13, 2022 07:14

damip reviewed

View reviewed changes

massa-consensus-exports/src/commands.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-consensus-exports/src/consensus_controller.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-graph/src/block_graph.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-graph/src/block_graph.rs Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-factory-worker/src/endorsement_factory.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-factory-worker/src/endorsement_factory.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-graph/src/block_graph.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-graph/src/block_graph.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-pool-worker/src/endorsement_pool.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-storage/src/block_indexes.rs Outdated Show resolved Hide resolved

adrien-zinger and others added 2 commits

September 13, 2022 10:07


          Simplify get latest blockclique

e094b8d

Avoid useless lock, cleanup useless index by threads in storage.

doc

3abd791

Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>

Member

damip commented Sep 13, 2022 •

edited

Loading

Some things to check:

in the endorsement pool, when we prune the pool after receiving a finality notification from consensus, now we should remove all endorsements whose slot <= latest_final_slot[endorsement.thread]
in the endorsement factory, when creating an endorsement that will be included in slot S, we should produce the endorsement at time(S) - t0/2
make sure we don't create endorsements to be included in period 0


          Endorsments changes: clean up parameter and warnings

341f813

damip reviewed

View reviewed changes

massa-graph/src/block_graph.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-graph/src/block_graph.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-graph/src/block_graph.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-graph/src/block_graph.rs Outdated Show resolved Hide resolved


          Resolve review for endorsements changes

84554e4

Fix pruning methods old endorsements
Short circuit at the first clique on looking latest BC block
Change next slot timings

adrien-zinger commented

View reviewed changes

massa-factory-worker/src/endorsement_factory.rs Outdated Show resolved Hide resolved

damip added 2 commits

September 13, 2022 14:59


          improve endorsement prod timings

0d6d081


          correct endorsement behavior

fdcf6b2

damip approved these changes

View reviewed changes

damip requested changes

View reviewed changes

Member

damip left a comment

OK, let's not merge yet tho (breaking)

damip mentioned this pull request

Change endorsements #2976

Closed

damip changed the base branch from main to prepare_testnet_15

September 13, 2022 14:54

damip merged commit 12c7e42 into prepare_testnet_15

damip approved these changes

View reviewed changes

AurelienFT deleted the change_endorsements branch

May 29, 2023 08:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet