Change endorsements

[qdrn]

Endorsements should satisfy the following constraints:

• Endorsements should be created and propagated to the network by endorsers at half-slot time.
• Endorsements should endorse the best parent in the given thread as seen by the endorser at this timestamp.
• Endorsements created at a half-period can only be included in the block of the next period.

Side note: currently when we include the endorsements in a block we verify that they endorse the parent of the created block in this thread.

cc @sebastien-forestier @leoloco

[damip]

Current implementation

Currently, we PoS-select endorsement creators targeting the blockclique block at slot (period, thread) if any.
The endorsements selected at (period, thread) are created/emitted at time genesis_timestamp + period * t0 + thread * (t0/thread_count) + t0/2.

Implementation change

We need to PoS-select endorsement creators that are allowed to be included in blocks at slot (period, thread).
The endorsements selected at (period, thread) are created/emitted at time genesis_timestamp + period * t0 + thread * (t0/thread_count) - t0/2 and endorse the latest blockclique (or final) block of their thread.

[sebastien-forestier]

One additionnal change to be discussed: take into account the compatible endorsements in the pool to compute the cliques fitness

[qdrn]

One additionnal change to be discussed: take into account the compatible endorsements in the pool to compute the cliques fitness

What cases do you have in mind ? If you create a block you create the one that gives the clique with the highest fitness (I guess ?). If you create endorsements then you probably don't have the other endorsements.

[damip]

Part 1 is done here: #3004
Not merging yet (breaking)

[AurelienFT]

Waiting for feeedback from research team.

[qdrn]

I think we can close this one. Right ?

[AurelienFT]

take into account the compatible endorsements in the pool to compute the cliques fitness

This hasn't been discuss but could be moved to a discussion

[qdrn]

take into account the compatible endorsements in the pool to compute the cliques fitness

This hasn't been discuss but could be moved to a discussion

Yeah, I don't think it belongs to an issue.