Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable auto index creation #109

Merged
merged 4 commits into from
Jun 29, 2023
Merged

Conversation

farshidz
Copy link
Collaborator

@farshidz farshidz commented Jun 29, 2023

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature

  • What is the current behavior? (You can also link to an open issue here)
    When adding documents to an index that does not exist, Marqo automatically and silently creates an index with a default index configuration.

  • What is the new behavior (if this is a feature change)?
    Attempting to add documents to an index that does not exist will fail with an error. Indices must be created explicitly before adding documents.
    See Disable auto create index marqo#516

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    Yes. Users must ensure an index exists before documents are added, or must handle the error. Code that relies on the removed automatic index creation behaviour will fail.

  • Other information:

@farshidz farshidz marked this pull request as ready for review June 29, 2023 05:51
@Mehul-Porwal
Copy link

You may want to squash the commits before merging

@pandu-k
Copy link
Collaborator

pandu-k commented Jun 29, 2023

You may want to squash the commits before merging

good point - I've disabled other merge methods

@pandu-k pandu-k merged commit f6bc307 into mainline Jun 29, 2023
@pandu-k pandu-k deleted the farshid/disable-auto-create-index branch June 29, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants