Disable auto create index #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0f73c8 to
8e7035b
Compare
8e7035b to
40e5630
Compare
pandu-k
reviewed
Jun 28, 2023
This was referenced Jun 29, 2023
pandu-k
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
When adding documents to an index that does not exist, Marqo automatically and silently creates an index with a default index configuration.
What is the new behavior (if this is a feature change)?
Attempting to add documents to an index that does not exist will fail with an error. Indices must be created explicitly before adding documents.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes. Users must ensure an index exists before documents are added, or must handle the error. Code that relies on the removed automatic index creation behaviour will fail.
Have unit tests been run against this PR? (Has there also been any additional testing?)
Yes. Only unit tests.
Related Python client changes (link commit/PR here)
None
Related documentation changes (link commit/PR here)
None
Other information:
Please check if the PR fulfills these requirements