Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent extra fields in index settings #365

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Conversation

pandu-k
Copy link
Collaborator

@pandu-k pandu-k commented Mar 2, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug

  • What is the current behavior? (You can also link to an open issue here)
    [BUG] validate index settings for models #341

  • What is the new behavior (if this is a feature change)?
    Extra fields in the root and index_default fields in index settings fail validation.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    Todo

  • Related Python client changes (link commit/PR here)
    n/a

  • Related documentation changes (link commit/PR here)
    n/a

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@pandu-k
Copy link
Collaborator Author

pandu-k commented Mar 2, 2023

@pandu-k pandu-k had a problem deploying to marqo-test-suite March 2, 2023 06:02 — with GitHub Actions Failure
@pandu-k pandu-k temporarily deployed to marqo-test-suite March 2, 2023 07:31 — with GitHub Actions Inactive
@pandu-k pandu-k merged commit 55bbb9c into mainline Mar 3, 2023
@pandu-k pandu-k deleted the tighter_index_validation branch March 3, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants