Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] validate index settings for models #341

Closed
jn2clark opened this issue Feb 22, 2023 · 1 comment
Closed

[BUG] validate index settings for models #341

jn2clark opened this issue Feb 22, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@jn2clark
Copy link
Contributor

Is your feature request related to a problem? Please describe.
the index settings validation does not catch the model field if it is in the incorrect part of the settings json

Describe the solution you'd like
if the model key is present in the settings but not nested correctly it should raise an error

Describe alternatives you've considered
none

Additional context
none

@jn2clark jn2clark added the enhancement New feature or request label Feb 22, 2023
@jn2clark
Copy link
Contributor Author

{
    "index_defaults": {
        "image_preprocessing": {
            "patch_method": null
        },
        "normalize_embeddings": true,
        "text_preprocessing": {
            "split_length": 2,
            "split_method": "sentence",
            "split_overlap": 0
        },
        "treat_urls_and_pointers_as_images": false
    },
    "model": "open_clip/ViT-L-14/laion2b_s32b_b82k",
    "number_of_shards": 5,
    "treat_urls_and_pointers_as_images": true
}

an example where the model key is incorrectly located but does not raise an error. this causes the default model to load

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant