-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to change SelectArrayInput
's size
prop and fix outlined
variant
#8562
Add ability to change SelectArrayInput
's size
prop and fix outlined
variant
#8562
Conversation
This will supersede #8465 |
Hey @slax57 When do you think you could check and merge this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review, our team is a bit short-handed at the moment but hopefully this will get better soon 😇
packages/ra-ui-materialui/src/input/SelectArrayInput.stories.tsx
Outdated
Show resolved
Hide resolved
@slax57 thanks for the review and the feedback. Addressed all the comments. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise I'm good with the changes, thanks!
82fff1a
to
1c78905
Compare
1c78905
to
6b2845c
Compare
6b2845c
to
21e1e8b
Compare
@slax57 PTAL |
Thanks! |
SelectArrayInput
's size
prop and fix outlined
variant
I noticed the label had the same issues in the ReferenceManyInput (ra-relationships) as well. Does this fix that too? |
@davidhenley |
@slax57 No, I'm talking about ReferenceManyInput. The label is off only on the outline variant and doesn't match the other inputs. Just wondered if this fixed that as well, but seems to be a different bug. Since it's enterprise, I'm not sure where to open that issue though. <TextInput source="name" helperText="some text" />
<ReferenceManyInput reference="products" target="testId">
<SimpleFormIterator>
<TextInput source="size" />
</SimpleFormIterator>
</ReferenceManyInput> |
@davidhenley Thanks for the additional info. |
fixes #8515
This PR fixes 2 issues with
SelectArrayInput
:size
propoutlined
size
prop onSelectArrayInput
was hardcoded tosmall
which was preventing modifying size of the input through MUI's theming system.Additionally, when setting
SelectArrayInput
variant tooutlined
label of the input wasn't showing correctly. This is fixed by addinginput
prop withOutlinedInput
component when variant is set tooutlined
.Before:
After: