Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded size value for SelectArrayInput #8515

Closed
amilosmanli opened this issue Dec 16, 2022 · 2 comments
Closed

Hardcoded size value for SelectArrayInput #8515

amilosmanli opened this issue Dec 16, 2022 · 2 comments

Comments

@amilosmanli
Copy link
Contributor

What you were expecting:
SelectArrayInput to honor defaultProps set for MuiSelect component

What happened instead:
SelectArrayInput has a hardcoded size prop that is not possible to override

Steps to reproduce:
add following to the components sections of the theme

MuiSelect: {
      defaultProps: {
        variant: 'outlined',
        size: 'medium',
      },
    },

Related code:
https://github.com/marmelab/react-admin/blob/master/packages/ra-ui-materialui/src/input/SelectArrayInput.tsx#L295

Other information:

Environment

  • React-admin version: latest
  • Last version that did not exhibit the issue (if applicable):
  • React version:
  • Browser:
  • Stack trace (in case of a JS error):
@antoinefricker
Copy link
Contributor

Thanks for your feedback.
We would gladly welcome a PR from the community for this bugfix!

@slax57
Copy link
Contributor

slax57 commented Mar 13, 2023

Fixed in #8562

@slax57 slax57 closed this as completed Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants