Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Fix radiobuttongroup inse referenceInput #8214

Closed
wants to merge 1 commit into from
Closed

Feat: Fix radiobuttongroup inse referenceInput #8214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/ra-core/src/controller/input/useReferenceInputController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,10 @@ export const useReferenceInputController = <RecordType extends RaRecord = any>(
finalData = possibleValuesData;
finalTotal = total;
} else {
finalData = [referenceRecord, ...possibleValuesData];
finalData = [...possibleValuesData];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only solution I have found for now.

During a short time, referenceRecord becomes the selected value in the radio group.
So we have a finalData with a duplicate.

I will add it in two steps with a check to avoid the rendering jump

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you use a JavaScript Set instead

https://developer.mozilla.org/fr/docs/Web/JavaScript/Reference/Global_Objects/Set

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had tried this technique, but it creates a "flick" when rendering the component.

flickrendering.mp4

if (finalData.indexOf(referenceRecord) === -1) {
finalData.push(referenceRecord);
}
finalTotal = total == null ? undefined : total + 1;
}

Expand Down