Feat: Fix radiobuttongroup inse referenceInput #8214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arimet
commented
Sep 30, 2022
| @@ -125,7 +125,10 @@ export const useReferenceInputController = <RecordType extends RaRecord = any>( | |||
| finalData = possibleValuesData; | |||
| finalTotal = total; | |||
| } else { | |||
| finalData = [referenceRecord, ...possibleValuesData]; | |||
| finalData = [...possibleValuesData]; | |||
There was a problem hiding this comment.
This is the only solution I have found for now.
During a short time, referenceRecord becomes the selected value in the radio group.
So we have a finalData with a duplicate.
I will add it in two steps with a check to avoid the rendering jump
There was a problem hiding this comment.
I suggest you use a JavaScript Set instead
https://developer.mozilla.org/fr/docs/Web/JavaScript/Reference/Global_Objects/Set
There was a problem hiding this comment.
I had tried this technique, but it creates a "flick" when rendering the component.
flickrendering.mp4
fzaninotto
requested changes
Sep 30, 2022
| @@ -125,7 +125,10 @@ export const useReferenceInputController = <RecordType extends RaRecord = any>( | |||
| finalData = possibleValuesData; | |||
| finalTotal = total; | |||
| } else { | |||
| finalData = [referenceRecord, ...possibleValuesData]; | |||
| finalData = [...possibleValuesData]; | |||
There was a problem hiding this comment.
I suggest you use a JavaScript Set instead
https://developer.mozilla.org/fr/docs/Web/JavaScript/Reference/Global_Objects/Set
|
Superseded by #8229 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
radiobutton.mp4