Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix runtime error when type is not supplied to useNotify #6713

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Fix runtime error when type is not supplied to useNotify #6713

merged 2 commits into from
Oct 25, 2021

Conversation

danielhusar
Copy link
Contributor

@danielhusar danielhusar commented Oct 20, 2021 •
edited
Loading

When you dont supply type to the useNotify it will throw runtime error, even though type is marked as optional in the type.

This is a breaking change.

djhi
djhi approved these changes Oct 21, 2021
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@djhi djhi added this to the 3.19.1 milestone Oct 21, 2021
@danielhusar
Copy link
Contributor Author

Is there a way to autoformat?

@WiXSL
Copy link
Contributor

WiXSL commented Oct 21, 2021 •
edited
Loading

Is there a way to autoformat?

You have a prettier command in the project's scripts

@djhi djhi merged commit e61cd35 into marmelab:master Oct 25, 2021
@djhi
Copy link
Collaborator

djhi commented Oct 25, 2021

Thanks!

@WiXSL WiXSL mentioned this pull request Nov 10, 2021
Closed
@nidebo nidebo mentioned this pull request Nov 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.19.1
Development

Successfully merging this pull request may close these issues.
3 participants
@danielhusar @WiXSL @djhi